You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are trying to convert more and more core function dropdowns on the site to using <details>. I'm currently working on https://github.com/github/github/pull/78190 and we need the selected state on <summary class="btn"> without the .selected class being added since the <details> pattern uses no JavaScript.
I'm curious what you all think about this, and if there is a better solution. ⭐ Happy to explore.
Slightly off-topic of this PR, but I'm not quite sure where else to put it: Should we consider adding either <details> reset styles to primer-base or a utility class to reset them? I ask because @katmeister and I did some hacking in https://github.com/github/github/pull/77914/commits/8a9ab7f799492378bd9de2d6e5a6fd2be57956c0 that includes a reset snippet from one or your refactors, and I think it'd make it a lot easier to deprecate the details component/behavior in favor of the HTML5 elements.
That commit also adopts an approach that @keithamus suggested, minting some new classes: details-content--shown and --hidden vs. Details-content--shown. Maybe it's better to name them details-content--open and details-content--closed to be clearer, but what do you all think about that approach?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are trying to convert more and more core function dropdowns on the site to using
<details>. I'm currently working on https://github.com/github/github/pull/78190 and we need the selected state on<summary class="btn">without the.selectedclass being added since the<details>pattern uses no JavaScript.I'm curious what you all think about this, and if there is a better solution. ⭐ Happy to explore.
/cc @primer/ds-core